Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Prepare Special URDF script fail with success exit code #68

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

hello-fazil
Copy link
Contributor

Description

Prepare specialized URDF script fails with error code if unable to find URDF in an export folder which is expected during fresh production installs, stopping the Stretch Install shell scripts. Therefore this PR adds a try exception block to exit the script with success status after notifying the failure.

Testing procedure

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

Copy link
Collaborator

@hello-amal hello-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To follow up on this PR, I'll make the following changes:

  1. Run this script at launchtime if the required URDF doesn't exist.
  2. Modify this script to use stretch_description/stretch.urdf as opposed to exported_urdf (since the latter may not exist on older robots).

@hello-fazil hello-fazil merged commit f0ce7cb into master Jul 10, 2024
1 check passed
@hello-fazil hello-fazil deleted the bugfix/prep_special_urdf branch July 10, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants