fix: hello flag

hellocoop · Dec 23, 2024 · 1736518 · 1736518
1 parent 2244e39
commit 1736518
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/src/lib/components/Request/AuthorizationServer.svelte b/src/lib/components/Request/AuthorizationServer.svelte
@@ -1,6 +1,6 @@
 <script>
 	import { slide } from 'svelte/transition';
-	import { AUTHZ_SERVERS } from '$lib/constants.js';
+	import { AUTHZ_SERVERS, HAS_HELLO_DEV_FLAG } from '$lib/constants.js';
 	import ChevronY from '$components/ChevronY.svelte';
 	import CopyButton from '../CopyButton.svelte';
 	import { validateAuthzServer as validate } from '$lib/validate';
@@ -22,9 +22,10 @@
 		<ChevronY dir={dropdowns.server ? 'up' : 'down'} />
 	</button>
 	{#if dropdowns.server}
+		{@const showHelloExtended = HAS_HELLO_DEV_FLAG && isHelloMode}
 		{@const ALL_AUTHZ_SERVERS = [
 			...AUTHZ_SERVERS.SERVERS,
-			...(isHelloMode ? AUTHZ_SERVERS.HELLO_EXTEND_SERVERS : [])
+			...(showHelloExtended ? AUTHZ_SERVERS.HELLO_EXTEND_SERVERS : [])
 		]}
 		<ul class="space-y-2 mt-2" transition:slide|local={{ duration: 150 }}>
 			{#each ALL_AUTHZ_SERVERS as server}

diff --git a/src/lib/components/Request/HelloParams.svelte b/src/lib/components/Request/HelloParams.svelte
@@ -1,6 +1,6 @@
 <script>
 	import { slide } from 'svelte/transition';
-	import { PARAMS } from '$lib/constants.js';
+	import { PARAMS, HAS_HELLO_DEV_FLAG } from '$lib/constants.js';
 	import ChevronY from '$components/ChevronY.svelte';
 	import Tooltip from '$components/Tooltip.svelte';
 	import ProviderHintInput from '$components/Inputs/ProviderHintInput.svelte';
@@ -29,9 +29,10 @@
 		/>
 	</button>
 	{#if dropdowns.hello}
+		{@const showHelloExtended = HAS_HELLO_DEV_FLAG && isHelloMode}
 		{@const ALL_HELLO_PARAMS = [
 			...PARAMS.HELLO_PARAM.PARAMS,
-			...(isHelloMode ? PARAMS.HELLO_PARAM.HELLO_EXTEND_PARAMS : [])
+			...(showHelloExtended ? PARAMS.HELLO_PARAM.HELLO_EXTEND_PARAMS : [])
 		]}
 		<ul class="flex flex-col justify-center mt-2 space-y-2" transition:slide={{ duration: 150 }}>
 			{#each ALL_HELLO_PARAMS as param}

diff --git a/src/lib/components/Request/ScopeParam.svelte b/src/lib/components/Request/ScopeParam.svelte
@@ -1,6 +1,6 @@
 <script>
 	import { slide } from 'svelte/transition';
-	import { PARAMS } from '$lib/constants.js';
+	import { PARAMS, HAS_HELLO_DEV_FLAG } from '$lib/constants.js';
 	import ChevronY from '$components/ChevronY.svelte';
 	import Tooltip from '$components/Tooltip.svelte';
 	import { validateScopes as validate } from '$lib/validate.js';
@@ -24,7 +24,7 @@
 	>
 		<span class="font-medium text-base"> Scope Parameter </span>
 		<ChevronY dir={dropdowns.scope ? 'up' : 'down'} />
-		<Tooltip content="Scope Parameter Docs" , href="https://www.hello.dev/docs/scopes/" />
+		<Tooltip content="Scope Parameter Docs" href="https://www.hello.dev/docs/scopes/" />
 	</button>
 
 	{#if isOverridden}
@@ -34,13 +34,14 @@
 	{/if}
 
 	{#if dropdowns.scope}
+		{@const showHelloExtended = HAS_HELLO_DEV_FLAG && isHelloMode}
 		{@const ALL_STANDARD_SCOEPS = [
 			...PARAMS.SCOPE_PARAM.STANDARD,
-			...(isHelloMode ? PARAMS.SCOPE_PARAM.HELLO_EXTEND_STANDARD : [])
+			...(showHelloExtended ? PARAMS.SCOPE_PARAM.HELLO_EXTEND_STANDARD : [])
 		]}
 		{@const ALL_NON_STANDARD_SCOPES = [
 			...PARAMS.SCOPE_PARAM.NON_STANDARD,
-			...(isHelloMode ? PARAMS.SCOPE_PARAM.HELLO_EXTEND_NON_STANDARD : [])
+			...(showHelloExtended ? PARAMS.SCOPE_PARAM.HELLO_EXTEND_NON_STANDARD : [])
 		]}
 		<div
 			class="flex mt-2 space-x-2"

diff --git a/src/lib/constants.js b/src/lib/constants.js
@@ -172,4 +172,6 @@ const AUTHZ_SERVERS = {
 	]
 };
 
-export { PARAMS, AUTHZ_SERVERS, PROFILE_CLAIMS };
+const HAS_HELLO_DEV_FLAG = localStorage.getItem('plausible_ignore') === 'true';
+
+export { PARAMS, AUTHZ_SERVERS, PROFILE_CLAIMS, HAS_HELLO_DEV_FLAG };