more ui fixes

hellocoop · Dec 4, 2024 · 3756dd3 · 3756dd3
1 parent 29fb9f2
commit 3756dd3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/App.svelte b/src/App.svelte
@@ -98,6 +98,10 @@
 		await initShiki(); // syntax highlighting
 
 		mounted = true;
+
+		// focus authz response section for better mobile UX
+		// runs after 'mounted' to ensure UI is rendered
+		if (claims) focusAuthzResponseSection();
 	});
 
 	function saveStateToLocalStorage() {
@@ -230,8 +234,6 @@
 		} catch (err) {
 			console.error(err);
 			showErrorNotification = true;
-		} finally {
-			focusAuthzResponseSection();
 		}
 	}
 
@@ -254,8 +256,6 @@
 		} catch (err) {
 			console.error(err);
 			showErrorNotification = true;
-		} finally {
-			focusAuthzResponseSection();
 		}
 	}
 

diff --git a/src/lib/utils.js b/src/lib/utils.js
@@ -1,3 +1,4 @@
+import { tick } from 'svelte';
 import { createAuthRequest } from '@hellocoop/helper-browser';
 
 function cleanUrl() {
@@ -78,7 +79,8 @@ async function sendPlausibleEvent() {
 	}
 }
 
-function focusAuthzResponseSection() {
+async function focusAuthzResponseSection() {
+	await tick(); // ensures UI updates are complete
 	const ele = document.querySelector('#authz-response-container');
 	if (ele) ele.scrollIntoView();
 }