-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add yamale and yamllint extra-args flags #383
Conversation
a8e1d67
to
1306e46
Compare
@acobaugh thanks for the PR, can you please rebase this with the latest code in main? |
1306e46
to
11cd089
Compare
@cpanato Done! |
hey, just realize that you need to generate the docs
|
ac637db
to
0a44a5a
Compare
@cpanato done! |
there are some failures, can you take a look when you have a chance? thanks! |
0a44a5a
to
5b46f14
Compare
Alright, tests passed locally for me this time. Let's give this another go. |
there are some conflicts are you able to rebase? thanks |
5b46f14
to
a77237d
Compare
@cpanato done! |
i will run that locally |
@acobaugh there are some tests failures can you check that when you have some time? |
need some rebase |
Signed-off-by: Andy Cobaugh <[email protected]>
a77237d
to
1895fc2
Compare
rebased. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
What this PR does / why we need it:
This adds
--yamllint-extra-args
and--yamale-extra-args
flags toct lint
. Yamllint in particular has optionsWhich issue this PR fixes:
This allows users of
ct
to fix or workaround helm/chart-testing-action#70 by passing--yamllint-extra-args -f,standard
.Special notes for your reviewer:
The issue with the default
github
formatting with yamllint is github seems to swallow the important information that is output whenyamllint
detects it is running under a github action, as can be seen in helm/chart-testing-action#70.If it would be preferable to just hardcode
-f standard
intoct
, I can issue a PR to do that, too, but being able to fully customize how yamale and yamllint are run might be useful for other situations, too.