Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add yamale and yamllint extra-args flags #383

Closed
wants to merge 1 commit into from

Conversation

acobaugh
Copy link

What this PR does / why we need it:

This adds --yamllint-extra-args and --yamale-extra-args flags to ct lint. Yamllint in particular has options

Which issue this PR fixes:

This allows users of ct to fix or workaround helm/chart-testing-action#70 by passing --yamllint-extra-args -f,standard.

Special notes for your reviewer:

The issue with the default github formatting with yamllint is github seems to swallow the important information that is output when yamllint detects it is running under a github action, as can be seen in helm/chart-testing-action#70.

If it would be preferable to just hardcode -f standard into ct, I can issue a PR to do that, too, but being able to fully customize how yamale and yamllint are run might be useful for other situations, too.

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch from a8e1d67 to 1306e46 Compare January 25, 2022 22:44
@cpanato
Copy link
Member

cpanato commented Mar 14, 2022

@acobaugh thanks for the PR, can you please rebase this with the latest code in main?

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch from 1306e46 to 11cd089 Compare March 14, 2022 15:53
@acobaugh
Copy link
Author

@cpanato Done!

@cpanato
Copy link
Member

cpanato commented Mar 23, 2022

hey, just realize that you need to generate the docs

go build -o ct-bin ./ct/main.go

$ ./ct-bin doc-gen
Generating docs...
Done.

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch 2 times, most recently from ac637db to 0a44a5a Compare March 23, 2022 13:51
@acobaugh
Copy link
Author

@cpanato done!

@cpanato
Copy link
Member

cpanato commented Apr 1, 2022

there are some failures, can you take a look when you have a chance? thanks!

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch from 0a44a5a to 5b46f14 Compare April 5, 2022 04:42
@acobaugh
Copy link
Author

acobaugh commented Apr 5, 2022

Alright, tests passed locally for me this time. Let's give this another go.

@cpanato
Copy link
Member

cpanato commented Jul 28, 2022

there are some conflicts are you able to rebase? thanks

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch from 5b46f14 to a77237d Compare July 28, 2022 17:01
@acobaugh
Copy link
Author

@cpanato done!

@cpanato cpanato requested a review from davidkarlsen July 29, 2022 12:06
@cpanato
Copy link
Member

cpanato commented Jul 29, 2022

i will run that locally

@cpanato
Copy link
Member

cpanato commented Jul 29, 2022

@acobaugh there are some tests failures can you check that when you have some time?

@cpanato
Copy link
Member

cpanato commented Sep 27, 2022

need some rebase

@acobaugh acobaugh force-pushed the feat/lint-extra-args branch from a77237d to 1895fc2 Compare October 12, 2022 15:40
@acobaugh
Copy link
Author

rebased.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 11, 2023
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants