Add hermitian() to matrix gallery
#1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ClaudiaComito I couldn't figure out the split logic for this. Can you please review the PR? |
for more information, see https://pre-commit.ci
|
Thank you for the PR! |
ClaudiaComito
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Thanks again @swaptr and apologies for the delay. I suggest to use ht.random.randn instead of arange, and that also allows specifying a split axis.
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
ClaudiaComito
requested changes
Aug 18, 2023
|
Thank you for the PR! |
|
Thank you for the PR! |
5 tasks
ClaudiaComito
changed the base branch from
main
to
1073-Add_Hermitian_to_matrix_gallery
ClaudiaComito
merged commit 084475c
into
helmholtz-analytics:1073-Add_Hermitian_to_matrix_gallery
3 checks passed
ClaudiaComito
added a commit
that referenced
this pull request
Sep 4, 2023
* add test_hermitian() * Add `hermitian()` to matrix gallery (#1086) * hermitian: add function definition * implement hermitian * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Set default dtype to complex * Edit docs * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix reference to types --------- Co-authored-by: Claudia Comito <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix operand split for binary operation * add double precision tests * faster solution for non-positive definite hermitian * Update matrixgallery.py Updated docs for `hermitian` Added scaling factor for the positive definite matrices Added distinction of real and complex data types * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update test_matrixgallery.py extended tests: * added tests for the positive definite case and real data-types * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reformatting with precommit * formatted the docstring as raw (r""" ...) in order to let flake8 be fine with latex formulas... * corrected a typo in the tests... --------- Co-authored-by: swaptr <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Fabian Hoppe <[email protected]> Co-authored-by: Hoppe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
hermitian()to generate random hermitian matrices of sizen.Issue/s resolved: #1073
Changes proposed:
hermitian()toutils.data.matrixgallery.Type of change
Memory requirements
Performance
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no