Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up array declaration when possible in iomodule #1089

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

shahpratham
Copy link
Collaborator

@shahpratham shahpratham commented Feb 5, 2023

Description

Replaced factories.array with DNDarray in io.py
Issue/s resolved: #797

Changes proposed:

  • factories.array -> dndarray.DNDarray

Type of change

enhancement

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Title of PR is suitable for corresponding CHANGELOG entry

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Feb 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #1089 (fe82322) into main (687dcfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1089   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          75       75           
  Lines       10705    10708    +3     
=======================================
+ Hits         9866     9869    +3     
  Misses        839      839           
Flag Coverage Δ
unit 92.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
heat/core/io.py 89.50% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@github-actions
Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing a few small changes. Apologies for the delay @shahpratham !

heat/core/io.py Outdated Show resolved Hide resolved
heat/core/io.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito changed the title IO: Replaced factories.array() with DNDarray Speed up array declaration when possible in iomodule Aug 18, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@ClaudiaComito ClaudiaComito merged commit 7830d74 into main Aug 18, 2023
45 checks passed
@mtar mtar deleted the enhancement/797-io-dndarray branch February 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module io: replace factories.array() with DNDarray construct where possible
3 participants