-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up array declaration when possible in io
module
#1089
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1089 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 75 75
Lines 10705 10708 +3
=======================================
+ Hits 9866 9869 +3
Misses 839 839
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you for the PR! |
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing a few small changes. Apologies for the delay @shahpratham !
Thank you for the PR! |
io
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Description
Replaced factories.array with DNDarray in io.py
Issue/s resolved: #797
Changes proposed:
Type of change
enhancement
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no