Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction to < 7 processes in test_spectral.py #1200

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Aug 21, 2023

see #655 for the bug that cannot be reproduced anymore

@github-actions
Copy link
Contributor

Thank you for the PR!

@ghost
Copy link

ghost commented Aug 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1200 (d69eb67) into main (086457a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files          75       75           
  Lines       10699    10699           
=======================================
  Hits         9864     9864           
  Misses        835      835           
Flag Coverage Δ
unit 92.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Aug 22, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @mrfh92 !

@ClaudiaComito ClaudiaComito added testing Implementation of tests, or test-related issues merge queue labels Aug 22, 2023
@github-actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito changed the title Remove restriction to < 7 processes in test_spectral.py (bug cannot be reproduced anymore) Remove restriction to < 7 processes in test_spectral.py Aug 23, 2023
@ClaudiaComito ClaudiaComito merged commit 089ab2f into main Aug 23, 2023
45 checks passed
@mtar mtar deleted the 655-Lanzcos_init_introducing_NaNs_into_DNDarray_before_torch_eig_call branch February 28, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge queue testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants