Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed randomized SVD #1561

Merged
merged 41 commits into from
Oct 18, 2024
Merged

Distributed randomized SVD #1561

merged 41 commits into from
Oct 18, 2024

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Jul 8, 2024 •
edited
Loading

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Adds randomized SVD and corresponding interface in PCA

Issue/s resolved: #1457

Type of change

  • New feature (non-breaking change which adds functionality)

Does this change modify the behaviour of other functions? If so, which?

yes (slightly, of PCA) / no (all other functionality)

@mrfh92 mrfh92 marked this pull request as ready for review August 12, 2024 13:30
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (4b3e570) to head (18a570d).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   92.13%   92.17%   +0.03%     
==========================================
  Files          83       83              
  Lines       12173    12209      +36     
==========================================
+ Hits        11216    11254      +38     
+ Misses        957      955       -2
Flag Coverage Δ
unit 92.17% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 mentioned this pull request Aug 22, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 mentioned this pull request Aug 30, 2024
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Oct 4, 2024

@ClaudiaComito thanks for reading so carefully that you found all the typos I had overlooked 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

4 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Thank you for the PR!

@mrfh92 mrfh92 mentioned this pull request Oct 4, 2024
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thank you for the PR!

ClaudiaComito
ClaudiaComito approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @mrfh92 !

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito changed the title Features/1457 Add randomized SVD Distributed randomized SVD Oct 18, 2024
@mrfh92 mrfh92 merged commit 7e44cd3 into main Oct 18, 2024
43 checks passed
@mrfh92 mrfh92 deleted the features/1457-Add_randomized_SVD branch October 18, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaudiaComito ClaudiaComito ClaudiaComito approved these changes

@mtar mtar Awaiting requested review from mtar

Assignees
No one assigned
Labels
benchmark PR ESAPCA relevant for the ESA-funded project "ESAPCA" high-level functions High-level machine-learning algorithms linalg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add randomized SVD/PCA
3 participants
@mrfh92 @mtar @ClaudiaComito