Creating one egraph in generate-candidates
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavpanchekha
approved these changes
Jan 27, 2025
| @@ -104,14 +104,14 @@ | |||
|
|
|||
| ; node -> natural | |||
| ; inserts an expression into the e-graph, returning its e-class id. | |||
|
|
|||
There was a problem hiding this comment.
Not a big deal but better to avoid making unnecessary whitespace changes like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the idea suggested by @pavpanchekha of removing
simplifystep for taylor expansions and, instead, pass them intorun-rrfunction.Or more general, this PR eliminates creation of one Egraph for simplifying taylor expansions.
Instead, taylor expansions are inputted to the same egraph as
rewriteuses.The result is: about the same accuracy has been achieved but with a large speedup.
Maybe it is worth trying increasing
*node-limit*after this update.