Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asl][reference] Rename "statically evaluable" -> "symbolically evaluable" #1136

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

hrutvik
Copy link
Collaborator

@hrutvik hrutvik commented Jan 17, 2025

Note that we deliberately do not rename "static interpretation" (implementation in StaticInterpreter.ml) as this is actually doing static interpretation during type-checking.

We only rename the concept of "statically evaluable" to "symbolically evaluable" - i.e. anything which uses side-effect analysis to decide whether an expression can be evaluated deterministically without side-effects.

Copy link
Collaborator

@Roman-Manevich Roman-Manevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the term static evaluation should be kept for everything related to the static interpreter.

asllib/StaticInterpreter.ml Outdated Show resolved Hide resolved
asllib/StaticInterpreter.mli Outdated Show resolved Hide resolved
Copy link
Collaborator

@HadrienRenaud HadrienRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Roman-Manevich Roman-Manevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Only two comments.

asllib/doc/ErrorCodes.tex Show resolved Hide resolved
asllib/doc/SideEffects.tex Outdated Show resolved Hide resolved
@hrutvik hrutvik marked this pull request as ready for review January 24, 2025 17:15
…able"

Note that we deliberately do not rename "static interpretation"
(implementation in `StaticInterpreter.ml`) as this is actually doing
static interpretation during type-checking.

We only rename the concept of "statically evaluable" to "symbolically
evaluable" - i.e. anything which uses side-effect analysis to decide
whether an expression can be evaluated deterministically without side-effects.
@hrutvik hrutvik changed the title [asl][reference] Rename "static evaluation" -> "symbolic evaluation" [asl][reference] Rename "statically evaluable" -> "symbolically evaluable" Jan 24, 2025
@hrutvik hrutvik merged commit 7575ed3 into herd:master Jan 24, 2025
3 checks passed
@hrutvik hrutvik deleted the doc-symbolic-eval branch January 24, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants