-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asl][reference] Rename "statically evaluable" -> "symbolically evaluable" #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the term static evaluation should be kept for everything related to the static interpreter.
c2f769e
to
3ece4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Only two comments.
3ece4b5
to
d07d878
Compare
d07d878
to
87f467b
Compare
…able" Note that we deliberately do not rename "static interpretation" (implementation in `StaticInterpreter.ml`) as this is actually doing static interpretation during type-checking. We only rename the concept of "statically evaluable" to "symbolically evaluable" - i.e. anything which uses side-effect analysis to decide whether an expression can be evaluated deterministically without side-effects.
87f467b
to
fb093a1
Compare
Note that we deliberately do not rename "static interpretation" (implementation in
StaticInterpreter.ml
) as this is actually doing static interpretation during type-checking.We only rename the concept of "statically evaluable" to "symbolically evaluable" - i.e. anything which uses side-effect analysis to decide whether an expression can be evaluated deterministically without side-effects.