[asl][reference] Synchronize reference for #1140 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienRenaud
requested changes
Jan 24, 2025
There was a problem hiding this comment.
This is not what has been implemented in #1140, in particular, the default case when otherwise is None is different.
We could argue that the two are equivalent, or edit one or the other, but we can't merge as is.
What should we edit? The code or the documentation?
asllib/doc/GlobalDeclarations.tex
Outdated
| \item applying $\controlflowfromstmt$ to $\vbody$ yields $\vctrlflow$. | ||
| \item applying $\controlflowfromstmt$ to $\vbody$ yields $\vcf_\vbody$; | ||
| \item \Proseeqdef{$\vcf_\otherwise$}{$\controlflowfromstmt(\vo)$ if $\votherwiseopt = \langle\vo\rangle$ | ||
| and $\assertednotinterrupt$ if $\votherwiseopt$ is $\None$}; |
There was a problem hiding this comment.
This is not what is implemented, maybe it is equivalent, but in that case we have to argue that it is equivalent etc.
There was a problem hiding this comment.
You're right. I think it is equivalent though.
ASL Reference fix + Stdlib arguments renaming
Roman-Manevich
force-pushed
the
asl-reference-synch-for-1140
branch
from
d42126d to
9de1f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TypingRule.ControlFlowFromStmt in synchrony with PR #1140.