Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asl] Fix 0.0 ^ 0 == 1.0 #1143

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[asl] Fix 0.0 ^ 0 == 1.0 #1143

merged 1 commit into from
Jan 24, 2025

Conversation

HadrienRenaud
Copy link
Collaborator

@HadrienRenaud HadrienRenaud commented Jan 24, 2025 •
edited
Loading

  • Fix bug and now 0.0 ^ 1 == 1.0
  • include a very small gain for {a..n} POW c which now does not contain the extra value 1.
  • the base count for {a..b} OP {c..d} got put in par with the other type of interval operations in the generated tests with QCheck
  • the long factor for QCheck tests of static operations on intervals has been multiplied by 10, which means they take a few minutes to complete on my computer. This is not really a problem as those tests can only be triggered manually.

hrutvik
hrutvik approved these changes Jan 24, 2025
View reviewed changes
asllib/tests/ConstraintBinops.ml Show resolved Hide resolved
@HadrienRenaud HadrienRenaud changed the title [asl] Fix 0.0 ^ 0 == 1 [asl] Fix 0.0 ^ 0 == 1.0 Jan 24, 2025
@HadrienRenaud HadrienRenaud merged commit c0d4803 into herd:master Jan 24, 2025
3 checks passed
@HadrienRenaud HadrienRenaud deleted the asl-fix-zero-pow branch January 24, 2025 16:03
@Roman-Manevich Roman-Manevich mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrutvik hrutvik hrutvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HadrienRenaud @hrutvik