[cat] Ensure that ETS3 includes ordering rules that apply for ETS2 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artkhyzha if you have moment I would like your thoughts on this. I contemplated a fix for ETS3 in herd7 but I thought having the fix in the cat file will make it more accessible. |
artkhyzha
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thank you, @relokin, LGTM.
I understand the alternative solution would be to automatically enable ets2 when ets3 is enabled. Not sure why the alternative would be preferable. In principle, one may assume that ets3 implies ets2, but the transliteration of the rules in the Arm ARM does not presently indicate that, so not sure if the assumption is really intuitive.
Signed-off-by: Nikos Nikoleris <[email protected]>
Signed-off-by: Nikos Nikoleris <[email protected]>
|
Thanks the review @artkhyzha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.