Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix back quote in coappearances example schema for Go implementation #31

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix back quote in coappearances example schema for Go implementation #31

merged 1 commit into from
Feb 27, 2018

Conversation

artemnikitin
Copy link
Contributor

I propose this little change because in the current state it will not work with Go implementation.
In case of Go:

Raw string literals are character sequences between back quotes, as in `foo`. 
Within the quotes, any character may appear except back quote.

https://golang.org/ref/spec#String_literals

VeaaC
VeaaC approved these changes Feb 23, 2018
View reviewed changes
Copy link
Collaborator

@VeaaC VeaaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create an issue for our generator to "escape" such things?

@artemnikitin artemnikitin mentioned this pull request Feb 23, 2018
Open
@artemnikitin
Copy link
Contributor Author

I created an issue #32

@artemnikitin
Copy link
Contributor Author

@boxdot @imagovrn What are you thinking about it?

@boxdot boxdot merged commit a2faba6 into heremaps:master Feb 27, 2018
@artemnikitin artemnikitin deleted the fix-coappearances-schema branch February 28, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeaaC VeaaC VeaaC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemnikitin @VeaaC @boxdot