Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASL-592 Extension Cleanup Capability #374

Open
wants to merge 23 commits into
base: v2
Choose a base branch
from
Open

CASL-592 Extension Cleanup Capability #374

wants to merge 23 commits into from

Conversation

rlakde
Copy link
Member

@rlakde rlakde commented Oct 30, 2024

No description provided.

rlakde and others added 14 commits August 19, 2024 11:38
@rlakde
Initial Changes.
4b77d3f 
Signed-off-by: lakde <[email protected]>
@rlakde
Fix Unit Tests
ba85d9d 
Signed-off-by: lakde <[email protected]>
@rlakde
Review Fixes
1befc37 
Signed-off-by: lakde <[email protected]>
@rlakde
Merge branch 'v2' into CASL-321_Extn_Sub_Environments
fec7f97
@rlakde
Update openapi.yaml
58995d3
@rlakde
Update gradle.properties
7ec0f86
@rlakde
Update gradle.properties
acc5770
@rlakde @hirenkp2000 @cyberhead-pl
Rebase CASL-321 (#371)
b07480f 
* Fixed array patching (#365)

* Fixed array patching
* corrected patcher test expectation

* Fix thread stuck issue + addtnl logs (#368)

* Added logs to troubleshoot thread hanging issue
* CASL-258 unreleased lock fix (#358)
* Fixed array patching (#365) (#367)
* corrected patcher test expectation
* updated version
* updated changelog
---------

Co-authored-by: Pawel Mazurek <[email protected]>

---------

Co-authored-by: Hiren Patel <[email protected]>
Co-authored-by: Pawel Mazurek <[email protected]>
@rlakde
Update reusable-build-and-publish.yml
3e55ff9
@rlakde
Update gradle.properties
dbd6e79
@rlakde
Update openapi.yaml
9ea31d5
@rlakde
Merge branch 'v2' into CASL-321_Extn_Sub_Environments
c802b92
@rlakde
Add Interface IExtensionInit
0b204a5
@rlakde
Add instanceCache logic.
528c950
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 42.68% -0.3% 🍏
Files changed 31.9% 🍏

Module Coverage
here-naksha-lib-ext-manager 72.1% -9.49% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 74.3% -14.96% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

hirenkp2000
hirenkp2000 requested changes Nov 4, 2024
View reviewed changes
here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/IExtensionInit.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-hub/src/main/java/com/here/naksha/lib/hub/NakshaHub.java Outdated Show resolved Hide resolved
here-naksha-lib-hub/src/main/java/com/here/naksha/lib/hub/NakshaHub.java Outdated Show resolved Hide resolved
here-naksha-lib-hub/src/main/java/com/here/naksha/lib/hub/NakshaHub.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.65% -0.33% 🍏
Files changed 30.08% 🍏

Module Coverage
here-naksha-lib-ext-manager 70.45% -11.56% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ExtensionCache.java 74.3% -14.96% 🍏
AmazonS3Helper.java 59.57% 🍏
ValueTuple.java 0% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.4% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.81% -0.02% 🍏
here-naksha-lib-hub 25.01% -5.8% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.64% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.29% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.81% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Code Coverage

Overall Project 42.68% -0.28% 🍏
Files changed 38.29% 🍏

Module Coverage
here-naksha-lib-ext-manager 73.99% -7.25% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 76.54% -12.12% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Code Coverage

Overall Project 42.67% -0.25% 🍏
Files changed 38.82% 🍏

Module Coverage
here-naksha-lib-ext-manager 75.39% -5.23% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 79.07% -8.94% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

hirenkp2000
hirenkp2000 requested changes Nov 5, 2024
View reviewed changes
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Show resolved Hide resolved
here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Code Coverage

Overall Project 42.68% -0.27% 🍏
Files changed 38.51% 🍏

Module Coverage
here-naksha-lib-ext-manager 74.7% -7.28% 🍏
here-naksha-lib-core 32.8% -0.02% 🍏
here-naksha-lib-hub 25% -5.83% 🍏
Files
Module File Coverage
here-naksha-lib-ext-manager ValueTuple.java 100% 🍏
ExtensionCache.java 77.91% -12.47% 🍏
AmazonS3Helper.java 59.57% 🍏
here-naksha-lib-core Extension.java 0% -24.14% 🍏
ExtensionConfig.java 0% -9.09% 🍏
here-naksha-lib-hub NakshaHub.java 1.43% -18.75% 🍏

hirenkp2000
hirenkp2000 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@hirenkp2000 hirenkp2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Do not merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirenkp2000 hirenkp2000 hirenkp2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlakde @hirenkp2000