changing startVersion and endVersion in changeset api as optional #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunil Jaiswal <[email protected]>
…tartVersion directly on the api. Signed-off-by: Lucas Ceni <[email protected]>
Signed-off-by: Lucas Ceni <[email protected]>
goshev
approved these changes
Oct 18, 2024
Signed-off-by: Lucas Ceni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Implementation: To retrieve all changeset collections for a given space, the current implementation requires fetching the start and end versions via the statistics API or passing arbitrary values (e.g., startVersion=0 and endVersion=99999). These parameters are mandatory.
Solution: This update makes startVersion and endVersion optional parameters. If the changeset collection API is called without these parameters, it will return all changesets for the given space. If startVersion and endVersion are provided, the API will return changesets based on the specified versions.