Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image runs for Coverage generation #891

Closed
wants to merge 2 commits into from
Closed

Use image runs for Coverage generation #891

wants to merge 2 commits into from

Conversation

jounathaen
Copy link
Member

I think it might make sense to include them in the coverage generation.

Alternative:

  • Create an integration test that executes these images

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 49.33333% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (6d936b1) to head (d6ad145).

Files with missing lines Patch % Lines
src/hypercall.rs 0.00% 29 Missing ⚠️
src/linux/x86_64/kvm_cpu.rs 0.00% 5 Missing ⚠️
src/bin/uhyve.rs 0.00% 3 Missing ⚠️
src/params.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   70.26%   70.06%   -0.20%     
==========================================
  Files          24       24              
  Lines        2959     3017      +58     
==========================================
+ Hits         2079     2114      +35     
- Misses        880      903      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen
Copy link
Member Author

Hmmm, closing this, as it doesn't change the coverage.

@jounathaen jounathaen closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant