Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Auctions config definition format #66

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Fix Auctions config definition format #66

merged 1 commit into from
Oct 26, 2024

Conversation

DapperDino
Copy link
Contributor

No description provided.

DannyIsYog
DannyIsYog reviewed Oct 14, 2024
View reviewed changes
Copy link

@DannyIsYog DannyIsYog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only for item_sets of weapons we could have weapons_auction instead of auction1

@DapperDino
Copy link
Contributor Author

Since this is only for item_sets of weapons we could have weapons_auction instead of auction1

Could do, but I was just following the naming used in the other definitions I looked at.

@novabyte novabyte merged commit 1d6aa55 into main Oct 26, 2024
1 check passed
@novabyte novabyte deleted the nf/auctions-config branch October 26, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyIsYog DannyIsYog DannyIsYog approved these changes

@zyro zyro Awaiting requested review from zyro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DapperDino @DannyIsYog @novabyte