Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept: Containerized Integration Tests #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lugehorsam
Copy link
Contributor

This is a POC on how an SDK can use an extended Nakama image loaded with rpc functions to run integration tests against.

See https://github.com/heroiclabs/nakama-clientsdk-test for how this image is built and the associated rpc functions. The image it builds is currently on Docker Hub: https://hub.docker.com/repository/docker/heroiclabs/nakama-clientsdk-test

For test social provider keys, I propose an optional bind mount from the host machine and corresponding optional tests that are triggered in each SDK if such keys exist.

Remaining Steps:

(1) Make client-sdk test image repository public (before merging!)
(2) Versioning for test image on Docker Hub and make it public also (before merging!)
(3) Integrate with Github Actions
(4) Finalize approach for test keys

@lugehorsam lugehorsam marked this pull request as ready for review September 11, 2020 16:42
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2021

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants