Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Console credentials from environment variables first #1249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toqueteos
Copy link
Contributor

@toqueteos toqueteos commented Jul 23, 2024

New contributor, I couldn't find any issues talking about this so I went for it directly.

I'll add whatever is missing/required.

The fact that the default credentials are known and always set is not very good from a security standpoint.

Having to mess around with config files and the entrypoint of the container seems a bit too tedious for something that could be resolved via, at most, two environment variables.

Other solutions:

  • Some people might not like getEnvOr existing in server/config.go, if at all, we could not set a fallback value by just using os.Getenv instead and modify all the Dockerfiles in build/ folder to set the default value(s) there, although that adds chore tasks for new architectures or updates happening in said files.
  • Modify nakama/flags to support reading from env vars if some struct tag is set (something like env:"KEY_NAME").

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@novabyte novabyte requested a review from zyro July 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants