Read Console credentials from environment variables first #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New contributor, I couldn't find any issues talking about this so I went for it directly.
I'll add whatever is missing/required.
The fact that the default credentials are known and always set is not very good from a security standpoint.
Having to mess around with config files and the entrypoint of the container seems a bit too tedious for something that could be resolved via, at most, two environment variables.
Other solutions:
getEnvOr
existing inserver/config.go
, if at all, we could not set a fallback value by just usingos.Getenv
instead and modify all the Dockerfiles inbuild/
folder to set the default value(s) there, although that adds chore tasks for new architectures or updates happening in said files.env:"KEY_NAME"
).