Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send correct value to api for grpc telemetry drains #3178

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: send correct value to api for grpc telemetry drains #3178

merged 2 commits into from
Jan 16, 2025

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Jan 15, 2025

https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE0000282ViQYAU/view

Description

Currently we are sending otlpgrpc as a value to API when creating a grpc telemetry drain. The correct value should be otlp.

Testing

  1. Pull down this branch and yarn build
  2. `./bin/run telemetry:add SOME_URL --app SOME_FIR_APP --transport grpc
  3. See success

@eablack eablack requested a review from a team as a code owner January 15, 2025 19:22
@eablack eablack self-assigned this Jan 15, 2025
k80bowman
k80bowman approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test to make sure we are sending the correct type?

@eablack eablack temporarily deployed to AcceptanceTests January 16, 2025 00:02 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests January 16, 2025 00:02 — with GitHub Actions Inactive
@eablack eablack merged commit 48b7f8a into main Jan 16, 2025
8 checks passed
@eablack eablack deleted the eb/fix-grpc-telemetry-drains branch January 16, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

Assignees

@eablack eablack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eablack @k80bowman