Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish transition to hex_core #738

Open
2 of 6 tasks
wojtekmach opened this issue Jan 21, 2020 · 5 comments
Open
2 of 6 tasks

Finish transition to hex_core #738

wojtekmach opened this issue Jan 21, 2020 · 5 comments

Comments

@wojtekmach
Copy link
Member

wojtekmach commented Jan 21, 2020

We're already using hex_core in a few places, this is what is left:

  • Replace Hex.API.* with :hex_api_*.
  • Add progress tracking to hex_core
  • Convert Hex.HTTP to a :hex_http adapter
  • Update Hex.Repo to :hex_repo to fetch data
  • Move Hex.Crypto* to hex_core
  • Remove Hex.Crypto in favor of directly vendored pbcs
@cgerling
Copy link
Contributor

@wojtekmach are any of the items still required to be done?

@ericmj
Copy link
Member

ericmj commented Nov 22, 2022

@cgerling They are all up for grabs 👍

@cgerling
Copy link
Contributor

Cool, I intend to create a PR to address the 1st, 3rd, and 4th items.

@cgerling
Copy link
Contributor

cgerling commented Apr 1, 2023

I noticed that :hex_repo doesn't have some functions that Hex.Repo needs, like get_docs/3, get_public_key/1, and get_installs/0, should I add those in hex_core before updating Hex.Repo?

@ericmj
Copy link
Member

ericmj commented Apr 27, 2023

I noticed that :hex_repo doesn't have some functions that Hex.Repo needs, like get_docs/3, get_public_key/1, and get_installs/0, should I add those in hex_core before updating Hex.Repo?

Yes. Can you open a PR to hex_core that adds the necessary functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants