Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hex_repo functions #140

Merged
merged 3 commits into from
May 7, 2023
Merged

Conversation

cgerling
Copy link
Contributor

@cgerling cgerling commented May 4, 2023

This PR creates the three functions mentioned in hexpm/hex#738, those functions are required in order to complete one of the items in that issue.

Copy link
Member

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I don’t think we should have get_installs as it is specific to hex.pm, ie other repositories would not have it. I think public key and docs ones make sense though.

@cgerling
Copy link
Contributor Author

cgerling commented May 4, 2023

In this case, should we keep the existing implementation of get_installs/0 in hex using HTTP directly?

@wojtekmach
Copy link
Member

yup!

@cgerling cgerling force-pushed the create-hex-repo-functions branch from aa4ccde to 455556f Compare May 4, 2023 23:43
@cgerling
Copy link
Contributor Author

cgerling commented May 4, 2023

I've removed the get_installs/1 from the PR

@wojtekmach wojtekmach merged commit 92adcbf into hexpm:main May 7, 2023
@wojtekmach
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants