Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for retirement_reason spec. #150

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix for retirement_reason spec. #150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed59654
Fix spec as per current implementation
paulo-ferraz-oliveira Jun 19, 2024
28145ef
Act on review comments: remove (privately) unused elements
paulo-ferraz-oliveira Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hex_api_release.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

-type publish_params() :: [{replace, boolean()}].

-type retirement_reason() :: other | invalid | security | deprecated | renamed.
-type retirement_reason() :: binary().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use this type anymore anywhere, can you remove it while at it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

28145ef


-type retirement_params() :: #{reason := retirement_reason(), message => binary()}.
-type retirement_params() :: #{binary() := binary()}.
%% @doc
%% Gets a package release.
%%
Expand Down
Loading