Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex_taball to be able to unpack list of files #95

Closed
wants to merge 2 commits into from

Conversation

RudolfMan
Copy link

@RudolfMan RudolfMan commented Jun 10, 2020

I would like to be able to extract particular file from hex_tarball.. (needed for this hexpm/diff#53)
Introduce second argument that might be a list of filenames and pass it down to hex_erl_tar along with the list of options in tuple {files, ListOfFiles} or an atom all_files (so that we could default unpack/2 to it)

unpack(Tarball, Output) ->
  unpack(Tarball, all_files, Output, hex_core:default_config()).

@ericmj do you think it's possible to move recently introduced last config param from hex_tarball:unpack/3 to hex_param:unpack/4 while master is not released yet?
Sorry for this late PR (should have done earlier)

@ericmj
Copy link
Member

ericmj commented Jun 22, 2020

It looks like we do not need this for hexpm/diff#53. Closing this for now, we can always reopen later.

@ericmj ericmj closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants