add command_line_override to tool class #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in vacation currently but this looks good. If you rebase so it can be tested it would be helpful! |
|
Enjoy your holiday - in these strange times. I retired 4 years ago and have just sort of come back from a very long holiday...:) Mind you, dealing with flake8 is making me wonder whether I made a wise move.... Tests now seem fine - thanks for letting me take care of it. |
|
yeah, flake8 is the bloody worst. I used to like it but lately it's more of an annoyance than producing anything useful for me. If you want two spaces there, great, some reformatter should add it for me, no sense in asking a human to do that. I'll turn it down a bit. thanks for the contribution and welcome back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1
This allows me to override at the level of the input and output command line to allow an application to generate correctly ordered positional parameters