Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move vitest to root using workspace config #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: move vitest to root using workspace config #483

wants to merge 1 commit into from

Conversation

jordanshatford
Copy link
Collaborator

closes: #459

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 75872ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:06am

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.16%. Comparing base (afa3bd6) to head (75872ef).

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #483       +/-   ##
===========================================
- Coverage   76.54%   56.16%   -20.38%     
===========================================
  Files          75       88       +13     
  Lines        6497     8858     +2361     
  Branches      632      647       +15     
===========================================
+ Hits         4973     4975        +2     
- Misses       1521     3867     +2346     
- Partials        3       16       +13
Flag Coverage Δ
unittests 56.16% <ø> (-20.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mrlubos
mrlubos reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about those failing tests?

@jordanshatford
Copy link
Collaborator Author

What about those failing tests?

Tests aren't failing locally. Not sure why this is happening

@mrlubos
Copy link
Member

mrlubos commented Apr 24, 2024

Okay I wait for you to do some more discovery?

@jordanshatford
Copy link
Collaborator Author

Okay I wait for you to do some more discovery?

Not sure I understand why its failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlubos mrlubos mrlubos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Vitest to root
2 participants
@jordanshatford @mrlubos