Avoid f"..." syntax
#66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know what's your policy for accommodating old versions, but the recent change broke this on older python (I'm using 3.4) because it doesn't have the `f"..."` syntax. If it's acceptable, then this switches it to plain strings which make it work again on that version.
|
Just to clarify, I personally would rather use the new syntax, and arguably I should update my environment --- but since piazza is intended for universities, and department setups might be outdated, I thought that in this case it might be better to just avoid the new syntax to make it work better in such situations. |
|
This is fine, but I would still prefer we at least use str.format here (which should still be supported in 3.4) instead of string concatenation: https://docs.python.org/3.5/library/stdtypes.html#str.format Can you make that update? Thanks. |
hfaran
requested changes
Sep 8, 2023
| 'https://piazza.com/class', | ||
| data=f'from=%2Fsignup&email={email}&password={password}&remember=on&csrf_token={csrf_token}' | ||
| 'https://piazza.com/class', | ||
| data='from=%2Fsignup&email=' + email + '&password=' + password + '&remember=on&csrf_token=' + csrf_token |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what's your policy for accommodating old versions, but the recent change broke this on older python (I'm using 3.4) because it doesn't have the
f"..."syntax. If it's acceptable, then this switches it to plain strings which make it work again on that version.