Fix tests for default preferred units (#1868)

* TST: fix ureg attribute default_preferred_units and set autoconvert_to_preferred=True in test of autoconvert * TST: Use class ureg so both regular and _DEFAULT_REGISTRY are tested * CNF: Add mip install to github ci run to test to_preferred --------- Co-authored-by: Dana Nadler <[email protected]>
hgrecco · Dec 3, 2023 · 04cc929 · 04cc929
1 parent 37127e1
commit 04cc929
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,7 +18,7 @@ jobs:
           - python-version: 3.9
             numpy: "numpy"
             uncertainties: "uncertainties"
-            extras: "sparse xarray netCDF4 dask[complete]==2023.4.0 graphviz babel==2.8"
+            extras: "sparse xarray netCDF4 dask[complete]==2023.4.0 graphviz babel==2.8 mip>=1.13"
     runs-on: ubuntu-latest
 
     env:

diff --git a/pint/testsuite/test_quantity.py b/pint/testsuite/test_quantity.py
@@ -374,8 +374,8 @@ def test_convert(self):
 
     @helpers.requires_mip
     def test_to_preferred(self):
-        ureg = UnitRegistry()
-        Q_ = ureg.Quantity
+        ureg = self.ureg
+        Q_ = self.Q_
 
         ureg.define("pound_force_per_square_foot = 47.8803 pascals = psf")
         ureg.define("pound_mass = 0.45359237 kg = lbm")
@@ -412,9 +412,9 @@ def test_to_preferred(self):
 
     @helpers.requires_mip
     def test_to_preferred_registry(self):
-        ureg = UnitRegistry()
-        Q_ = ureg.Quantity
-        ureg.preferred_units = [
+        ureg = self.ureg
+        Q_ = self.Q_
+        ureg.default_preferred_units = [
             ureg.m,  # distance      L
             ureg.kg,  # mass          M
             ureg.s,  # duration      T
@@ -427,9 +427,10 @@ def test_to_preferred_registry(self):
 
     @helpers.requires_mip
     def test_autoconvert_to_preferred(self):
-        ureg = UnitRegistry()
-        Q_ = ureg.Quantity
-        ureg.preferred_units = [
+        ureg = self.ureg
+        Q_ = self.Q_
+        ureg.autoconvert_to_preferred = True
+        ureg.default_preferred_units = [
             ureg.m,  # distance      L
             ureg.kg,  # mass          M
             ureg.s,  # duration      T