Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid numpy scalar deprecation warnings in __setitem__ #1880

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

dopplershift
Copy link
Contributor

NumPy as of 1.25 deprecated automatically converting any "scalar" with non-zero number of dimensions to a float value. Therefore, we should ensure our values have ndim == 0 before passing to math.isnan()

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

NumPy as of 1.25 deprecated automatically converting any "scalar" with
non-zero number of dimensions to a float value. Therefore, we should
ensure our values have ndim == 0 before passing to math.isnan()
Copy link

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #1880 will not alter performance

Comparing dopplershift:avoid-warning (5bc72ee) with master (fc1aeba)

Summary

✅ 439 untouched benchmarks

@hgrecco hgrecco merged commit 321ea75 into hgrecco:master Dec 3, 2023
33 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Dec 3, 2023

Thanks!

@dopplershift dopplershift deleted the avoid-warning branch December 4, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants