Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly implement dtype on numpy quantities #1922

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Jan 16, 2024

This is important because runtime-checkable protocols require the attribute to be in the class dict from 3.12 onwards, bypassing __getattr__.

  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Added an entry to the CHANGES file

Copy link

codspeed-hq bot commented Jan 16, 2024

CodSpeed Performance Report

Merging #1922 will not alter performance

Comparing keewis:dtype (7f5db09) with master (0f24b6f)

Summary

✅ 439 untouched benchmarks

@hgrecco hgrecco merged commit b50ddc5 into hgrecco:master Jan 20, 2024
32 of 34 checks passed
@keewis keewis deleted the dtype branch January 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants