Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing benchmark test #1981

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

andrewgsavage
Copy link
Collaborator

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #1981 will degrade performances by 37.6%

Comparing andrewgsavage:codecov (e87bfca) with master (e3f24ab)

Summary

⚡ 146 improvements
❌ 149 regressions
✅ 142 untouched benchmarks

⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master andrewgsavage:codecov Change
test_create_default_registry 2.7 s 3.9 s -31.85%
test_create_default_registry_use_cache 214 ms 296.2 ms -27.76%
test_base_units[False-angstrom/minute] 423 µs 195.8 µs ×2.2
test_base_units[False-kilometer/second] 1,264 µs 201.7 µs ×6.3
test_base_units[True-angstrom/minute] 156.9 µs 209 µs -24.93%
test_base_units[True-angstrom] 167.3 µs 227.1 µs -26.36%
test_base_units[True-kilometer/second] 148.1 µs 197.5 µs -25.04%
test_base_units[True-meter] 166.7 µs 226.3 µs -26.34%
test_build_cache 7.2 ms 11 ms -34.13%
test_convert_from_uc[False-key0] 622.3 µs 241.7 µs ×2.6
test_convert_from_uc[False-key1] 984 µs 326.8 µs ×3
test_getattr[False-angstrom] 254 µs 180.4 µs +40.78%
test_getattr[False-kilometer] 1,138.1 µs 180.9 µs ×6.3
test_getattr[False-meter] 259.3 µs 180.3 µs +43.83%
test_getattr[False-millisecond] 1,135.5 µs 180.7 µs ×6.3
test_getattr[False-minute] 253.5 µs 180.6 µs +40.35%
test_getattr[False-ms] 1.1 ms 1.6 ms -27.95%
test_getattr[False-second] 257 µs 188.5 µs +36.31%
test_getattr[True-ms] 1.1 ms 1.6 ms -29.51%
test_getitem[False-kilometer] 2.2 ms 1.4 ms +54.15%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@andrewgsavage andrewgsavage merged commit 6be06c6 into hgrecco:master May 12, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant