Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve pint-convert #2136

Merged
merged 1 commit into from
Feb 15, 2025
Merged

refactor: improve pint-convert #2136

merged 1 commit into from
Feb 15, 2025

Conversation

hgrecco
Copy link
Owner

@hgrecco hgrecco commented Feb 15, 2025

  • guard execution in __main__
  • move code to functions
  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

- guard execution in __main__
- move code to functions
Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #2136 will not alter performance

Comparing _pint_convert (4e98a5c) with master (4d354c9)

Summary

✅ 447 untouched benchmarks

@hgrecco hgrecco merged commit 541e9c4 into master Feb 15, 2025
57 checks passed
@hgrecco hgrecco deleted the _pint_convert branch February 15, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant