Ingredient grouping & equipment support for saltpepperskillet #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
reviewed
Nov 5, 2024
Comment on lines
+13
to
+19
| def ingredient_groups(self): | ||
| return group_ingredients( | ||
| self.ingredients(), | ||
| self.soup, | ||
| ".wprm-recipe-ingredient-group h4", | ||
| ".wprm-recipe-ingredient", | ||
| ) |
There was a problem hiding this comment.
At some point we should probably consider making WPRM ingredient-group support available as a Mixin (or perhaps a few mixins with different variants based on the WordPress plugin(s) in use) -- these defaults seem to appear fairly often.
jayaddison
reviewed
Nov 5, 2024
Comment on lines
+25
to
+32
| if equipment_container: | ||
| return [ | ||
| item.get_text(strip=True) | ||
| for item in equipment_container.find_all( | ||
| "div", class_="wprm-recipe-equipment-name" | ||
| ) | ||
| ] | ||
| return None |
There was a problem hiding this comment.
Suggested change
| if equipment_container: | |
| return [ | |
| item.get_text(strip=True) | |
| for item in equipment_container.find_all( | |
| "div", class_="wprm-recipe-equipment-name" | |
| ) | |
| ] | |
| return None | |
| if not equipment_container: | |
| return None | |
| return [ | |
| item.get_text(strip=True) | |
| for item in equipment_container.find_all( | |
| "div", class_="wprm-recipe-equipment-name" | |
| ) | |
| ] |
...and maybe get_equipment? :)
jayaddison
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.