Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

marko-bekhta
Copy link
Member

No description provided.

instead of the docker-compose that now fails
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone's having fun? 😁

Thanks a lot, but remember you need to update the dependencies in all relevant projects as well, to the exact same version. Otherwise it will still work, but build will take longer (because they'll update dependencies).

@@ -3,7 +3,7 @@
COMPOSE=podman-compose
if ! which "$COMPOSE" 2>&1 1>/dev/null
then
COMPOSE=docker-compose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This... is actually potentially dangerous. But ok if you tested it (I can't, I use podman).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ... with docker-compose there seems to be an error now: quarkusio/quarkusio.github.io#2056 (comment)

@marko-bekhta marko-bekhta merged commit 4d8cd5c into hibernate:main Aug 16, 2024
@yrodiere
Copy link
Member

Thanks a lot, but remember you need to update the dependencies in all relevant projects as well, to the exact same version. Otherwise it will still work, but build will take longer (because they'll update dependencies).

Thanks, I saw hibernate/hibernate.org#216 and hibernate/in.relation.to#200 , but I'll need another one for https://github.com/beanvalidation/beanvalidation.org/pulls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants