-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a query to estimate the gas of a contract call #878
Merged
gsstoykov
merged 16 commits into
main
from
00841-add-a-query-to-estimate-the-gas-of-a-contract-call
Jan 24, 2025
Merged
Add a query to estimate the gas of a contract call #878
gsstoykov
merged 16 commits into
main
from
00841-add-a-query-to-estimate-the-gas-of-a-contract-call
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
gsstoykov
changed the title
00841 add a query to estimate the gas of a contract call
(WIP) Add a query to estimate the gas of a contract call
Jan 14, 2025
Signed-off-by: gsstoykov <[email protected]>
gsstoykov
changed the title
(WIP) Add a query to estimate the gas of a contract call
Add a query to estimate the gas of a contract call
Jan 21, 2025
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
rwalworth
reviewed
Jan 22, 2025
Co-authored-by: Rob Walworth <[email protected]> Signed-off-by: gsstoykov <[email protected]>
Co-authored-by: Rob Walworth <[email protected]> Signed-off-by: gsstoykov <[email protected]>
Co-authored-by: Rob Walworth <[email protected]> Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
rwalworth
reviewed
Jan 22, 2025
Signed-off-by: gsstoykov <[email protected]>
rwalworth
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gsstoykov
deleted the
00841-add-a-query-to-estimate-the-gas-of-a-contract-call
branch
January 24, 2025 07:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A new
MirrorNodeContractQuery
class has been introduced to support EVM gas estimation and simulation. This query class provides two distinct types of queries:MirrorNodeContractCallQuery
– Executes a contract call and returns the result, simulating the execution of the contract.MirrorNodeContractEstimateGasQuery
– Estimates the gas usage for a contract call, allowing developers to understand the cost of executing a transaction.The inputs for these queries match those of
ContractExecuteTransaction
, making it easy for developers to calculate the cost of a follow-up transaction.The
MirrorNodeContractQuery
issues an HTTP request to theapi/v1/contracts/call
endpoint of the Mirror Node Web3 module, which supports both gas estimation and transient simulation of state-changing transactions. This enables accurate cost predictions and helps developers optimise their contract interactions before executing them on the network.Related issue(s):
Fixes #841
Notes for reviewer:
Design was agreed upon from discussions for Java/GO but could be reworked in the future as it is not fully extendable. The C++ SDK implements the design so it aligns with the other SDKs.
Checklist