-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing JT-173 (backport of modified version of PR made by phax) #287
Conversation
0a02261
to
42b9fe7
Compare
Added UT for IOUtils new function. |
Do we have a jaxb-maven project to confirm it works? Seems his issue was about ordering of schemas. |
All of existings jaxb-maven projects tests confirm that there is no regression. The main goal of this PR is to have files resolution as close as includes items even if files are not returned in a consistent way across build platforms. |
Do we have a test project that uses "*" to references schemas and have schemas in a non-matching folder to make sure they do not get included? User's original dynamic list (issue showed up as resolution when really wide):
|
The goal of this fix is to ensure that the order of files specified in included configuration section is respected and used in plugin, no matter how plexus returns them by DirectoryScanner since order is not consistent. See issue codehaus-plexus/plexus-utils#70 in plexus-utils
42b9fe7
to
30f349b
Compare
Reworked on the PR We use the same patternmatcher as plexus-utils does to check if returned file does match each include pattern in configuration order to sort them this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Phax does this PR which doesn't break build and fixes his issue #173
Without it, he forked the project and maintains it (with jakarta support).