Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JT-285 - previous ref to maven-jaxb2-plugin changed to jaxb-tools #291

Merged
merged 1 commit into from
Aug 8, 2023
Merged

JT-285 - previous ref to maven-jaxb2-plugin changed to jaxb-tools #291

merged 1 commit into from
Aug 8, 2023

Conversation

laurentschoelens
Copy link
Collaborator

Fixing issue #285 by changing ref to new repo URL

@laurentschoelens
Copy link
Collaborator Author

Also fixed the README.md containing <<< / === / >>> from previous merge

mattrpav
mattrpav requested changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things..

  1. This is two unrelated changes in 1 PR
  2. README.md has the merge >>> clean-ed up, but not the url (as in the PR title).

Please split and fix

mattrpav
mattrpav approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad.. missed the url in the text output of the Mojo.java. This is good to go

@mattrpav mattrpav added this to the 2.0.4 milestone Aug 8, 2023
@mattrpav mattrpav self-assigned this Aug 8, 2023
@mattrpav mattrpav merged commit badf414 into highsource:master Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrpav mattrpav mattrpav approved these changes

Assignees

@mattrpav mattrpav

Labels
None yet
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentschoelens @mattrpav