refactor!: Update Cl.serialize to return string instead of bytes

hirosystems · Oct 24, 2024 · baa1a27 · baa1a27
1 parent 37e7c31
commit baa1a27
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/cli/tests/cli.test.ts b/packages/cli/tests/cli.test.ts
@@ -76,14 +76,14 @@ describe('decode_cv', () => {
 
   test('Should decode from hex to repr', async () => {
     const list = Cl.list([1, 2, 3].map(Cl.int));
-    const serialized = bytesToHex(Cl.serialize(list));
+    const serialized = Cl.serialize(list);
     const result = await decodeCV(mainnetNetwork, [serialized, 'repr']);
     expect(result).toEqual('(list 1 2 3)');
   });
 
   test('Should decode from hex to pretty print', async () => {
     const list = Cl.list([1, 2, 3].map(Cl.int));
-    const serialized = bytesToHex(Cl.serialize(list));
+    const serialized = Cl.serialize(list);
     const result = await decodeCV(mainnetNetwork, [serialized, 'pretty']);
     expect(result).toEqual('(list\n  1\n  2\n  3\n)');
   });

diff --git a/packages/transactions/src/cl.ts b/packages/transactions/src/cl.ts
@@ -9,7 +9,7 @@ import {
   noneCV,
   responseErrorCV,
   responseOkCV,
-  serializeCVBytes,
+  serializeCV,
   someCV,
   standardPrincipalCV,
   stringAsciiCV,
@@ -270,15 +270,15 @@ export const tuple = tupleCV;
 /**
  * `Cl.serialize` — Serializes a Clarity JS object to the equivalent hex-encoded representation
  *
- * Alias for {@link serializeCVBytes}
+ * Alias for {@link serializeCV}
  * @example
  * ```
  * import { Cl } from '@stacks/transactions';
  * Cl.serialize(Cl.uint(100));
  * ```
  * @see {@link deserialize}
  */
-export const serialize = serializeCVBytes;
+export const serialize = serializeCV;
 /**
  * `Cl.deserialize` — Deserializes a hex string to the equivalent Clarity JS object
  *

diff --git a/packages/transactions/src/clarity/serialize.ts b/packages/transactions/src/clarity/serialize.ts
@@ -158,6 +158,7 @@ function serializeStringUtf8CV(cv: StringUtf8CV) {
 export function serializeCV(value: ClarityValue): string {
   return bytesToHex(serializeCVBytes(value));
 }
+
 /** @ignore */
 export function serializeCVBytes(value: ClarityValue): Uint8Array {
   switch (value.type) {