Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow read-only headers in fetch #1745

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: allow read-only headers in fetch #1745

merged 1 commit into from
Oct 17, 2024
+4 −2

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 17, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.16.1
e.g. npm install @stacks/[email protected] --save-exact

This fixes a bug where in some instances the headers property is a read-only getter and cannot be re-assigned.

Taken from the other PR

Closes #1737

@janniks janniks requested a review from zone117x October 17, 2024 13:39
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 1:39pm

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/network/src/fetch.ts 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks merged commit 3c19b93 into main Oct 17, 2024
9 of 10 checks passed
@janniks janniks deleted the fix/header-set branch October 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zone117x zone117x zone117x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @zone117x