refactor update stackstransaction constructor to options object #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janniks
commented
Oct 23, 2024
•
janniks
commented
- Rename StacksTransaction, so we can use the name for a better more human readable alternative in the future
- Update to accept an options object instead
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
c0ef9c2
to
4db76a6
Compare
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
from
54c8722
to
9e99ed7
Compare
beguene
approved these changes
Oct 24, 2024
| @@ -40,3 +40,5 @@ export type NonFungiblePostCondition = { | |||
| }; | |||
|
|
|||
| export type PostCondition = StxPostCondition | FungiblePostCondition | NonFungiblePostCondition; | |||
|
|
|||
| export type PostConditionModeName = 'allow' | 'deny'; | |||
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
4db76a6
to
8a72ccb
Compare
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
from
7144c1b
to
5ed8a66
Compare
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
8a72ccb
to
695a0c7
Compare
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
from
5ed8a66
to
6d66e7a
Compare
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
695a0c7
to
8c4466d
Compare
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
2 times, most recently
from
44a094e
to
de8cfc7
Compare
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
8c4466d
to
74cb952
Compare
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
from
de8cfc7
to
c20b7bc
Compare
janniks
force-pushed
the
10-23-refactor_remove_unneeded_deserialize_overloads
branch
from
74cb952
to
06980cf
Compare
Base automatically changed from
10-23-refactor_remove_unneeded_deserialize_overloads
to
next
October 25, 2024 18:56
janniks
force-pushed
the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
from
c20b7bc
to
9e16d64
Compare
janniks
deleted the
10-23-refactor_update_stackstransaction_constructor_to_options_object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.