Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change getStxAddress to use network parameter #1752

Merged

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 23, 2024

This PR was published to npm with the version 6.14.1-pr.88+9b9cd4f3
e.g. npm install @stacks/[email protected]+9b9cd4f3 --save-exact

  • Minor refactor to allow another method to use the network parameter

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:02pm

@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from 7144c1b to 5ed8a66 Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 912069b to 37e7c31 Compare October 24, 2024 15:12
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/wallet-sdk/src/models/account.ts 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 37e7c31 to 9b9cd4f Compare October 25, 2024 12:05
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from 5ed8a66 to 6d66e7a Compare October 25, 2024 12:05
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 9b9cd4f to 91423d8 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch 2 times, most recently from 44a094e to de8cfc7 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch 2 times, most recently from f22c9a6 to 8dda5fc Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from de8cfc7 to c20b7bc Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 8dda5fc to f58788b Compare October 25, 2024 18:56
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from c20b7bc to 9e16d64 Compare October 25, 2024 18:56
Base automatically changed from 10-23-refactor_update_stackstransaction_constructor_to_options_object to next October 25, 2024 18:56
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from f58788b to 3bb149d Compare October 25, 2024 18:57
@janniks janniks merged commit 8abc510 into next Oct 25, 2024
1 of 2 checks passed
@janniks janniks deleted the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch October 25, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants