Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
codepitbull committed Jan 24, 2025
1 parent e2e9012 commit 77a251c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ public void writeConfigToXML(final @NotNull Writer writer) {

configFileContent = fragmentResult.getRenderResult(); //must happen before env rendering so templates can be used with envs
configFileContent = EnvVarUtil.replaceEnvironmentVariablePlaceholders(configFileContent);
log.error("Resulting file {}", configFileContent);
final ByteArrayInputStream is =
new ByteArrayInputStream(configFileContent.getBytes(StandardCharsets.UTF_8));
final StreamSource streamSource = new StreamSource(is);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ enum ConfigResult {SUCCESS, NO_OP, NEEDS_RESTART}
boolean needsRestartWithConfig(HiveMQConfigEntity config);

default boolean hasChanged(final T originalConfig, final T newConfig) {
if ((originalConfig != null && newConfig == null) || (originalConfig == null && newConfig != null)) {
log.error( "{} has changed {} {}", originalConfig.getClass().getSimpleName(), originalConfig == null, newConfig == null);
return true;
}

return !Objects.equals(originalConfig, newConfig);
}
}

0 comments on commit 77a251c

Please sign in to comment.