Postgresql protocol adapter Alpha #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyolazabal
changed the title
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
DC2-DanielKrueger
force-pushed
the
postgresql-protocol-adapter
branch
from
601df9a to
d128f6a
Compare
codepitbull
reviewed
Jan 8, 2025
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
codepitbull
reviewed
Jan 8, 2025
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| class PostgreSQLProtocolAdapterInformationTest { |
There was a problem hiding this comment.
Just realized there are no integration tests.
Can you add testcontainers based integration tests please?
There was a problem hiding this comment.
We can also add some ITs with an started edge
anthonyolazabal
commented
Jan 9, 2025
...esql/src/main/java/com/hivemq/edge/adapters/postgresql/PostgreSQLPollingProtocolAdapter.java
Outdated
Show resolved
Hide resolved
add config option to set the connection timeout
codepitbull
approved these changes
Jan 10, 2025
| @Override | ||
| public @NotNull String getLogoUrl() { | ||
| // this is a default image that is always available. | ||
| return "/images/postgres-logo.jpg"; |
There was a problem hiding this comment.
Did you check the license of the image we use here?
We probably need a source ackonwledgement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create the first alpha version of PostgreSQL protocol adapter.
Changes
This PR includes the original code and the migration to SDK 2024.9 with the new tag concept. It only cover Northbound mapping.
Note
Pooling test is not implemented for this alpha version.