-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(29358): Refactor the Designer visual identity #745
Conversation
2861e1e
to
1710934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to look into refactoring all the code around position as I saw multiple instances of 44px
and similar calculations all over the place.
It wouldn't take much to refactor this and have 1 source of truth (or at least minimise these sources of truth) and make your life easier when a refactoring request or an adjustment is needed.
Approving anyway not to block you 🦣
hivemq-edge/src/frontend/src/extensions/datahub/designer/behavior_policy/BehaviorPolicyNode.tsx
Outdated
Show resolved
Hide resolved
hivemq-edge/src/frontend/src/extensions/datahub/designer/client_filter/ClientFilterNode.tsx
Outdated
Show resolved
Hide resolved
hivemq-edge/src/frontend/src/extensions/datahub/designer/data_policy/DataPolicyNode.tsx
Outdated
Show resolved
Hide resolved
hivemq-edge/src/frontend/src/extensions/datahub/designer/operation/OperationNode.tsx
Show resolved
Hide resolved
hivemq-edge/src/frontend/src/extensions/datahub/designer/operation/OperationNode.tsx
Outdated
Show resolved
Hide resolved
hivemq-edge/src/frontend/src/extensions/datahub/designer/operation/OperationNode.tsx
Outdated
Show resolved
Hide resolved
Once I want to save the ID of a data policy, it isn't stored; an error occurs after checking repeatedly. |
Pressing enter holds but clicking not |
Sorry, this is not true. The id of a data-policy is stored once the user left the focus one time from the data-policy node |
I think I noticed that issue but haven't been able to pin it down. Will look again, and opening a new ticket for it |
4bb9665
to
b42af0b
Compare
See https://hivemq.kanbanize.com/ctrl_board/57/cards/29358/details/
The PR introduces visual changes to most elements (nodes and edges) in the
Data Hub Designer
. The aim is to highlight the paradigms that are similar to theWorkspace
(selectable and draggable nodes, toolbar for commands, status) while ensuring the two tools are immediately differentiatedDesign
Designer
onSuccess
on aData Policy
or on failed transition in a `Behaviour Policy)The PR also improves the layout of the handles and, by effect, the alignment of nodes on a gid layout. It fixes https://hivemq.kanbanize.com/ctrl_board/57/cards/29435/details/
Out-of-scope
Before
After