Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Improve texts of protocol adapters descriptions #766

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

sfrehse
Copy link
Contributor

@sfrehse sfrehse commented Jan 28, 2025

The PR text improvements provided by Mary.

https://hivemq.kanbanize.com/ctrl_board/57/cards/29818/details/

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2025
@vanch3d
Copy link
Contributor

vanch3d commented Jan 28, 2025

Translations from the main pages (https://hivemq.kanbanize.com/ctrl_board/57/cards/29820/details/) and the UNS (https://hivemq.kanbanize.com/ctrl_board/57/cards/29819/details/) have also been fixed in this PR.
And the faulty test :-)

@vanch3d vanch3d self-assigned this Jan 28, 2025
@vanch3d vanch3d force-pushed the text-improvements-29818 branch from 27204e5 to afcfd3a Compare January 28, 2025 11:37
Copy link
Contributor

@h2xd h2xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐊

@vanch3d vanch3d force-pushed the text-improvements-29818 branch from afcfd3a to 5829199 Compare January 29, 2025 10:00
@vanch3d vanch3d merged commit cf2aa02 into master Jan 29, 2025
9 of 10 checks passed
@vanch3d vanch3d deleted the text-improvements-29818 branch January 29, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants