Tests: fix cached point parse contamination between tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
In back-compat mode the cycle point time zone is assumed to be local, whereas in normal mode it is assumed to be UTC. There was contamination of the point parse caching where the time zone would carry over from tests of back-compat vs normal mode
* We were using the pytest-env plugin to run the tests in a non-UTC time zone. * The pytest-env plugin doesn't work with pytest-xdist so this was being ignored. * Also due to the way TZ support works in Python, changing the env var whilst Python is running may or may not result in changes.
MetRonnie
force-pushed
the
tests-cache-tz
branch
from
f431aaf
to
8b2ac18
Compare
hjoliver
reviewed
Dec 21, 2023
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | ||
| python-version: ['3.7', '3.8', '3.10', '3.11'] |
There was a problem hiding this comment.
Yes, so we test non-UTC on one of the python versions
hjoliver
approved these changes
Dec 21, 2023
hjoliver
merged commit 9c4a7fb
into
hjoliver:fix-runahead-compute
32 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In back-compat mode the cycle point time zone is assumed to be local, whereas in normal mode it is assumed to be UTC. There was contamination of the point parse caching where the time zone would carry over from tests of back-compat vs normal mode.
Also removed pytest-env because it doesn't work with pytest-xdist (copied from master - see cylc@be46a11)