Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtrig arg validate #38

Closed
wants to merge 39 commits into from

Commits on Jan 24, 2024

  1. Fix bugs in cylc broadcast (cylc#5933)

    broadcast: fix issues with filepaths and hash characters
    
    * Fix traceback when using `cylc broadcast -F` with a relative filepath
    * Fix `#` char bug in `cylc broadcast`
    MetRonnie authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f4e2853 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. add example workflows (cylc#5773)

    add example workflows
    
    * Partially addresses cylc/cylc-doc#627
    * Add some examples of Cylc workflow implementation patterns.
    
    ---------
    
    Co-authored-by: Hilary James Oliver <[email protected]>
    Co-authored-by: Ronnie Dutta <[email protected]>
    3 people authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    08d9c53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94fd7ac View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    82af1f3 View commit details
    Browse the repository at this point in the history
  2. stop after cycle point: support offsets

    * Closes cylc#5939
    * Support offsets (measured from the ICP) for the `stop after cycle point`
      to mirror the behaviour of the `final cycle point`.
    * Add integration test to lock-down `stop after cycle point`
      interactions.
    oliver-sanders committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    870fb47 View commit details
    Browse the repository at this point in the history
  3. doc: correct spelling

    oliver-sanders committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a83df17 View commit details
    Browse the repository at this point in the history
  4. Merge pull request cylc#5936 from cylc/8.2.x-sync

    Merge 8.2.x-sync into master
    MetRonnie authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8a676a8 View commit details
    Browse the repository at this point in the history
  5. Merge pull request cylc#5951 from oliver-sanders/spellcheck

    doc: correct spelling
    hjoliver authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f6752d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Add integration tests for xtrigger validation, which provides simple …

    …examples for each of the built in xtriggers.
    
    - Xrandom validate function
    - Init test xrandom validate function
    - Add unit tests for validation of built in xtriggers
    wxtim committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6fea50f View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Ronnie Dutta <[email protected]>
    oliver-sanders and MetRonnie authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2bcad6b View commit details
    Browse the repository at this point in the history
  3. loosen xargs validation checks

    wxtim committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ea50b53 View commit details
    Browse the repository at this point in the history
  4. Tidy (cylc#5886)

    MetRonnie authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a8988df View commit details
    Browse the repository at this point in the history
  5. avoid use of assert

    wxtim committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b543af7 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. build(deps): bump codecov/codecov-action from 3 to 4

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    85492ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38a4e15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26bc684 View commit details
    Browse the repository at this point in the history
  4. fix doctest

    wxtim committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3013d21 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. spelling fixes

    wxtim committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    690fd5d View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Ronnie Dutta <[email protected]>
    oliver-sanders and MetRonnie authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    810f3be View commit details
    Browse the repository at this point in the history
  3. Update tests/unit/test_config.py

    Co-authored-by: Ronnie Dutta <[email protected]>
    oliver-sanders and MetRonnie authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    2887819 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Automatically validate xtrigger function signature (#59)

    * Remove redundant try block.
    
    * Fix changelog
    
    * Automatically validate xtrigger function signature
    
    ---------
    
    Co-authored-by: Hilary James Oliver <[email protected]>
    MetRonnie and hjoliver authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    72615f2 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Ronnie Dutta <[email protected]>
    wxtim and MetRonnie authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8b2d9d4 View commit details
    Browse the repository at this point in the history
  3. Don't record satisfied wall clock triggers in the DB (cylc#5923)

    Don't record satisfied xtriggers in the DB
    
    * Closes cylc#5911
    * Test that no wall_clock xtriggers are saved to the DB for a retry.
    
    ---------
    
    Co-authored-by: Ronnie Dutta <[email protected]>
    Co-authored-by: Oliver Sanders <[email protected]>
    3 people authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    57fe4ae View commit details
    Browse the repository at this point in the history
  4. Tidy

    MetRonnie committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    28e68fe View commit details
    Browse the repository at this point in the history
  5. Changelog

    MetRonnie committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f301d54 View commit details
    Browse the repository at this point in the history
  6. Merge pull request cylc#5953 from cylc/dependabot/github_actions/code…

    …cov/codecov-action-4
    
    build(deps): bump codecov/codecov-action from 3 to 4
    oliver-sanders authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    3df8835 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. fix flake8

    wxtim committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    124666b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'master' into 8.2.x-sync

    wxtim authored and MetRonnie committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6cfbe7f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. added suite state xtrigger for back-compat (cylc#5864)

    added suite state xtrigger for back commpat
    extended back compat a unit test
    added deprecation log message
    Replace icky unit test with functional test (#4)
    
    ---------
    
    Co-authored-by: Mark Dawson <[email protected]>
    markgrahamdawson and Mark Dawson authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b1822a6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request cylc#5957 from cylc/8.2.x-sync

    🤖 Merge 8.2.x-sync into master
    wxtim authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b1b189b View commit details
    Browse the repository at this point in the history
  3. fixed flake8 (cylc#5962)

    Co-authored-by: Mark Dawson <[email protected]>
    markgrahamdawson and Mark Dawson authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    381c691 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge pull request cylc#5956 from MetRonnie/cylc-lint

    cylc lint: deprecate `[cylc-lint]` in favour of `[tool.cylc.lint]` in `pyproject.toml`
    wxtim authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7bf0b7a View commit details
    Browse the repository at this point in the history
  2. Merge pull request cylc#5943 from oliver-sanders/5939

    stop after cycle point: support offsets
    wxtim authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    14711c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    8ab57ad View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    4eb7d82 View commit details
    Browse the repository at this point in the history
  2. Merge pull request cylc#5972 from cylc/8.2.x-sync

    🤖 Merge 8.2.x-sync into master
    oliver-sanders authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4515ace View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca6c64d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68dbfd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Improve xtrigger validation (#60)

    * Improve xtrigger validation
    
    * wall_clock: use placeholder function for signature validation & autodocs
    
    * Fix docstring for autodoc [skip ci]
    MetRonnie authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    933b273 View commit details
    Browse the repository at this point in the history