Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent malformed --pre options taking the scheduler down #46

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

wxtim
Copy link

@wxtim wxtim commented Mar 6, 2024

Replicate Bug

(copied from cylc#5658 (comment)) so you don't have to follow the link.

Running a noddy workflow

cylc set cylc-set/basic//1/bar --pre='1/*:succeeded'

Gets sent successfully to the scheduler but then casuses the scheduler to fail

...
      File "/media/tim/Data1/tims_code/metomi/cylc-flow/cylc/flow/config.py", line 2215, in get_taskdef
        raise WorkflowConfigError(str(exc))
    cylc.flow.exceptions.WorkflowConfigError: Illegal task name: *

However daft a user's choice of input to set is, I don't think it ought ever crash the scheduler: And I don't think that this is super daft thing to ask for.

@wxtim wxtim force-pushed the cylc-set-task.fix.bad-pre branch from 46b9ef6 to 3dfb29f Compare March 6, 2024 16:00
Copy link
Owner

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wxtim looks good.

@hjoliver hjoliver merged commit b8b2b10 into hjoliver:cylc-set-task Mar 10, 2024
24 of 26 checks passed
@wxtim wxtim deleted the cylc-set-task.fix.bad-pre branch March 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants