-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Alias and Fix Record Type Translation in ts2mls
#143
Conversation
I think we may separate |
I find it's better to be very lax and do semantic validation afterwards, because parsing errors are usually worse than semantic errors. |
OK! And to keep |
Not really no, we need |
ts2mls
ts2mls
Also fixed a typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
After addressing the comments don't forget to use "squash and merge" and clean up the commit message. |
Related Issue: #134